Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock Service: Add empty check before accessing first element of a response list #317

Conversation

GeoffreyKarnbach
Copy link
Contributor

Description

Bugfix

What does this PR do?

Ensure that get is not used on an empty list with a hardcoded access index of 0.

closes GH-304

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
23.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@ValentinFutterer ValentinFutterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the bug nicely :)

@ValentinFutterer ValentinFutterer merged commit a740ea3 into next Jan 8, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MockProjectServiceImpl crashes when you try to read a project that doesnt exist
2 participants