Global: Add sorting to DMPs, Storage, Datasets and other entities by ID to preserve order #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, this works fine, but wouldnt it be simpler to do the sorting in the Repo classes. The you dont need to distribute the code over Services and Mappers. For example in DMPRepo: |
GeoffreyKarnbach
force-pushed
the
gk/293-db-preserve-sequence-of-elements-in-lists
branch
from
cee2442 to
db325a0
Compare
…ID to preserve order
GeoffreyKarnbach
force-pushed
the
gk/293-db-preserve-sequence-of-elements-in-lists
branch
from
db325a0 to
7c7a76e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature / Functionality
What does this PR do?
Add sorting by ID for DMPs (getAll and get for logged in user), Storages, Datasets, Contributors and Costs within a DMP.
closes GH-293