Request refresh tokens #7984
Draft
Request refresh tokens #7984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close: #7820 Co-authored-by: ivk <[email protected]>
Issue caused by inline images not being replaced after a loadAll call (without notify) which sanitizes mail body. This is due to the replaceInlineImages call being inside a loadCompleteNotification listener. Fixed by calling loadAll *with* notify in reply. loadAll is also now only called when necessary. Close #6523 Co-authored-by: ivk <[email protected]>
Close #7692 Close #6568 Co-authored-by: bir <[email protected]> Co-authored-by: hrb-hub <[email protected]>
Crash caused by an uncaught exception due to popover requiring position information on iPad only but not on iPhone. Close #7914 Co-authored-by: paw-hub <[email protected]>
Close #7125 Co-authored-by: bir <[email protected]>
On some systems, a backend may not be detected correctly. In a lot of cases, this can occur if the user is not using one of a hardcoded list of desktop environments (you can see this list in xdg_util.cc as well as key_storage_util_linux.cc in GetDesktopEnvironment and SelectBackend respectively in Chromium's source code), and it determines this using environment variables. Basically, if Chromium is unable to detect your desktop environment this way, safeStorage will not be available in any way except basic_text. We don't really have any control over this outside of the preselectGnomeLibsecret() method which may or may not work, but users can override it with CLI args or just set an app password. As such, this commit allows basic_text to be used as a backend. Closes #7257
Issue caused by caching the initially selected language and not changing current language while switching language. Resolved by resetting lazyloaded when switching the system language. close: 7335
Made congratulation.svg same size as other svg files in welcome page to avoid different image sizes close: #6853 Co-authored-by: ivk <[email protected]>
This was passing in getNextHalfHour() which takes the current date, not the date from the viewmodel. close: #7962 Co-authored-by: paw <[email protected]>
"Calling this method has no effect." according to Apple docs. This was changed recently according to wayback machine. https://developer.apple.com/documentation/uikit/uiapplication/1622961-openurl Fixes #7944 Co-authored-by: paw-hub <[email protected]>
The inner dropdown container was overflowing the outer one instead of scrolling because its height was not restricted. This could be reproduced on a screen that's not tall enough e.g. small mobile screen or landscape orientation of the phone. Now we set the height to the one of the parent to always have correct height. Close #7937
charlag
reviewed
Nov 20, 2024
| while (true) { | ||
| // Don't want to use entityClient.loadAll in case the token expires in the middle of us getting entities and | ||
| // then we'd have to do it all over again... | ||
| const elements = await this.handleRequest(mailGroup, async (options) => { |
There was a problem hiding this comment.
we need to load and store them chunk by chunk so loadAll doesn't make sense anyway
paw-hub
force-pushed
the
7953-request-refresh-tokens
branch
from
a3d5dbf
to
490b8ef
Compare
Oh, dear. Co-authored-by: BijinDev <[email protected]>
paw-hub
force-pushed
the
7953-request-refresh-tokens
branch
from
490b8ef
to
a49d4b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7953