Fix text appearing grey while printing in dark mode #7948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgoedde
force-pushed
the
5781-grey-print-text
branch
from
3e10963
to
29d3d5d
Compare
- Own dialog, then, if user is happy, open App Store with write-review intent - Triggers: -- After using the app for minimum 7 days, we can show the dialog after the user created three events / after three mails -- When the user did 10 activities within a 28-day period. (sending and email creating event. ) -- After succeeding the paywall - Use device config to store data needed to trigger the dialog - Added tests - Added method to get the native app's installation date (Android & iOS) - Added comment about `SKStoreReviewController.requestReview()` deprecation Co-authored-by: arm <[email protected]> Co-authored-by: jat <[email protected]>
Co-authored-by: arm <[email protected]>
It was the caused by the different foreground and background contrast between the light mode and dark mode. This commit forces the light mode foreground and background to be used when printing.
armhub
force-pushed
the
5781-grey-print-text
branch
from
29d3d5d
to
c9fc62b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was the caused by the different foreground and background contrast between the light mode and dark mode.
This PR forces the light mode foreground and background to be used when printing.
Closes #5781.