Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filetype key value to Metadata #93

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

nmahdi14
Copy link

No description provided.

Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR. There are only two minor things!

@@ -47,6 +47,7 @@ protected void onCreate(Bundle savedInstanceState) {
client = new TusClient();
client.setUploadCreationURL(new URL("https://tusd.tusdemo.net/files/"));
client.enableResuming(new TusPreferencesURLStore(pref));
client.enableRemoveFingerprintOnSuccess();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not look related to this PR. Could you please undo it?

@@ -27,6 +27,11 @@ public TusAndroidUpload(Uri uri, Context context) throws FileNotFoundException {
cursor.moveToFirst();
String name = cursor.getString(nameIndex);

String mimType = resolver.getType(uri);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please name the variable mimeType?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants