add deprecation notices to cli cmds (#934)

tursodatabase · Jan 21, 2025 · 9751a45 · 9751a45
1 parent a136a64
commit 9751a45
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 0 deletions.
diff --git a/internal/cmd/db_attach.go b/internal/cmd/db_attach.go
@@ -8,6 +8,11 @@ import (
 	"github.com/tursodatabase/turso-cli/internal/turso"
 )
 
+func showAttachDeprecationNotice() {
+	fmt.Println(internal.Warn("Notice: Database ATTACH is deprecated."))
+	fmt.Println(internal.Warn("For more information, visit: https://tur.so/attach-deprecated\n"))
+}
+
 func init() {
 	dbConfigCmd.AddCommand(dbAttachCmd)
 	dbAttachCmd.AddCommand(dbEnableAttachCmd)
@@ -27,6 +32,7 @@ var dbEnableAttachCmd = &cobra.Command{
 	Args:              cobra.ExactArgs(1),
 	ValidArgsFunction: dbNameArg,
 	RunE: func(cmd *cobra.Command, args []string) error {
+		showAttachDeprecationNotice()
 		cmd.SilenceUsage = true
 		return updateAttachStatus(args[0], true)
 	},
@@ -38,6 +44,7 @@ var dbDisableAttachCmd = &cobra.Command{
 	Args:              cobra.ExactArgs(1),
 	ValidArgsFunction: dbNameArg,
 	RunE: func(cmd *cobra.Command, args []string) error {
+		showAttachDeprecationNotice()
 		cmd.SilenceUsage = true
 		return updateAttachStatus(args[0], false)
 	},
@@ -49,6 +56,7 @@ var dbShowAttachStatusCmd = &cobra.Command{
 	Args:              cobra.ExactArgs(1),
 	ValidArgsFunction: dbNameArg,
 	RunE: func(cmd *cobra.Command, args []string) error {
+		showAttachDeprecationNotice()
 		cmd.SilenceUsage = true
 		client, err := authedTursoClient()
 		if err != nil {

diff --git a/internal/cmd/db_create.go b/internal/cmd/db_create.go
@@ -12,6 +12,11 @@ import (
 	"github.com/tursodatabase/turso-cli/internal/turso"
 )
 
+func showSchemaDeprecationNotice() {
+	fmt.Println(internal.Warn("Notice: Schema Databases are deprecated."))
+	fmt.Println(internal.Warn("For more information, visit: https://tur.so/schema-deprecated\n"))
+}
+
 const MaxDumpFileSizeBytes = 8 << 30
 
 func init() {
@@ -39,6 +44,12 @@ var createCmd = &cobra.Command{
 	Short:             "Create a database.",
 	Args:              cobra.MaximumNArgs(1),
 	ValidArgsFunction: noFilesArg,
+	PreRunE: func(cmd *cobra.Command, args []string) error {
+		if schemaFlag != "" || typeFlag == "schema" {
+			showSchemaDeprecationNotice()
+		}
+		return nil
+	},
 	RunE: func(cmd *cobra.Command, args []string) error {
 		cmd.SilenceUsage = true
 		name, err := getDatabaseName(args)

diff --git a/internal/cmd/group_locations.go b/internal/cmd/group_locations.go
@@ -10,6 +10,11 @@ import (
 	"golang.org/x/exp/maps"
 )
 
+func showEdgeReplicaDeprecationNotice() {
+	fmt.Println(internal.Warn("Notice: Edge Replicas are deprecated."))
+	fmt.Println(internal.Warn("For more information, visit: https://tur.so/replicas-deprecated\n"))
+}
+
 var groupLocationsCmd = &cobra.Command{
 	Use:   "locations",
 	Short: "Manage your database group locations",
@@ -29,6 +34,8 @@ var groupLocationsListCmd = &cobra.Command{
 	Args:              cobra.ExactArgs(1),
 	ValidArgsFunction: noFilesArg,
 	RunE: func(cmd *cobra.Command, args []string) error {
+		showEdgeReplicaDeprecationNotice()
+
 		group := args[0]
 		if group == "" {
 			return fmt.Errorf("the first argument must contain a group name")
@@ -56,6 +63,8 @@ var groupLocationAddCmd = &cobra.Command{
 	Args:              cobra.MinimumNArgs(1),
 	ValidArgsFunction: locationsAddArgs,
 	RunE: func(cmd *cobra.Command, args []string) error {
+		showEdgeReplicaDeprecationNotice()
+
 		groupName := args[0]
 		if groupName == "" {
 			return fmt.Errorf("the first argument must contain a group name")
@@ -133,6 +142,8 @@ var groupsLocationsRmCmd = &cobra.Command{
 	Args:              cobra.MinimumNArgs(2),
 	ValidArgsFunction: locationsRmArgs,
 	RunE: func(cmd *cobra.Command, args []string) error {
+		showEdgeReplicaDeprecationNotice()
+
 		groupName := args[0]
 		if groupName == "" {
 			return fmt.Errorf("the group flag is required")