Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Windows build #58

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

chrissuozzo
Copy link
Contributor

Issue:
Fixes #43 / #54

Description of changes:
sqlite3-parser version must be > 0.8 and include the version bump to fallible-iterator to rectify the above build issues on Windows.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

`sqlite3-parser` version must be > 0.8, and include the version bump
to `fallible-iterator` to rectify compile issue on Windows.
@itowlson
Copy link

itowlson commented Dec 6, 2023

This fix would be really valuable for the Spin framework (https://github.com/fermyon/spin) too. At the moment we keep having to coerce libsql-client back to an earlier rev to work around the sqlite3-parser issue. Thanks!

@LucioFranco LucioFranco merged commit a432666 into tursodatabase:main Dec 7, 2023
1 check passed
@chrissuozzo chrissuozzo deleted the fix_windows_build branch December 7, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building on Windows machine fails for sqlite3-parser
3 participants