Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modem-manager-autosetup: Use optional mvno_match_data for APN selection #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

modem-manager-autosetup: Use optional mvno_match_data for APN selection #3

wants to merge 2 commits into from

Commits on Apr 8, 2024

  1. modem-manager-autosetup: Fix jq filter for apn without 'type' attribute 

    The initial jq filter used to extract the APN info from apns-conf.json
fails with:

``` text
jq: error (...): null (null) and string ("default") cannot have their containment checked
```
when one of the apn objects selected by mcc/mnc doesn't have a
'type' attribute (as is the case for mcc=262, mnc=07). As a result,
otherwise matching APN objects will not be considered.

This commit fixes the jq filter by checking for the presence of
the 'type' attribute.
    @ktetzlaff
    ktetzlaff committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c61ac41 View commit details
    Browse the repository at this point in the history

  2. modem-manager-autosetup: Use optional mvno_match_data for APN selection 

    In case that there are multiple APN definitions for the given
combination of 'mnc', 'nmc' (and 'type') and an 'mvno_match_data'
attribute of type 'imsi' exists, the 'mvno_match_data' can be used to
select the correct APN from a set of otherwise equivalent ones.

This commit adds an additional step which uses 'mvno_match_data' to
improve the APN selection process.
    @ktetzlaff
    ktetzlaff committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    7a91d59 View commit details
    Browse the repository at this point in the history