fix: project name cannot contain slash #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbhandari-turo
force-pushed
the
f/update_docker_compose_project_name
branch
from
e257cab to
689da4a
Compare
tagoro9
reviewed
Jan 8, 2024
pbhandari-turo
force-pushed
the
f/update_docker_compose_project_name
branch
from
689da4a to
45a88a9
Compare
tagoro9
approved these changes
Jan 8, 2024
|
🎉 This PR is included in version 1.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after update in gha runner to docker compose v2, some runs are failing with error like
project name must follow invalid project name "turo/dunlop-deployments-7451808450-1": must consist only of lowercase alphanumeric characters, hyphens, and underscores as well as start with a letter or numbercompose project name should not contain
/, this PR instead extracts the repo name from github.repository variable (uses last path in turo/...) and uses that to build project name