praxisdigital/moodle-opgaver#501 - Skip files larger than 100 MB #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue related to debug page due to a deprecated function
frederikmillingpytlick
force-pushed
the
fmp_moodle-opgaver-GH-501_400
branch
from
a2a7c5a to
d7ebb8a
Compare
…-opgaver-GH-501_400
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an issue where the plagiarism plugin tries to send some very large files to the checker. We're talking multiple gigabytes. This causes an out of memory fatal error since the file content is being loaded into memory, before sending to the checker.
I then looked up your file requirements and found that you limit it at 100 MB and thought why not skip them before attempting to send them forward :)
Feel free to reply with any wanted changes from my part :)