BE ContactsController #show #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCirbo
reviewed
Jan 6, 2025
| @@ -46,6 +46,25 @@ def create | |||
| end | |||
| end | |||
|
|
|||
| def show | |||
| if params[:id].blank? | |||
| render json: ErrorSerializer.format_error(ErrorMessage.new("Contact ID is missing", 400)), status: :bad_request | |||
There was a problem hiding this comment.
I like how you’re using ErrorSerializer to handle errors—keeps the responses consistent and user-friendly.
CCirbo
reviewed
Jan 6, 2025
| @@ -0,0 +1,73 @@ | |||
| require "rails_helper" | |||
There was a problem hiding this comment.
Great job on the tests here. You’ve covered both happy and sad paths well, especially with cases for missing, invalid, and expired tokens.
CCirbo
reviewed
Jan 6, 2025
| @@ -697,6 +697,43 @@ raw json body with all fields: | |||
| ] | |||
| }, | |||
| ``` | |||
| #### Show a Contact that belongs to a User (not company contact) | |||
There was a problem hiding this comment.
The README update is super clear and helpful. The sample request and response are a great addition for anyone using this endpoint and makes it clear what route and endpoint you are using.
jimmacur
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
By adding, in routes.rb,
:showto the:users(not:companies) nested:contactsresource and adding corresponding #show action to ContactsController, the FE can now access and render a users individual contacts. This is fully tested in Postman and green in RSpec.Motivation and Context
Issue #17 was affected by a prior refactor of the BE ContactsController that removed the #show action because of how the routes are now being nested. While building my ShowContact component on the FE, I was getting a mystery 500 error which led me to see that BE's main had been refactored.
Related Tickets
closes #66
Screenshots (if appropriate):
Added Test?
Checklist: