Refactor/job application application url uniqueness

README.md

@@ -260,6 +260,11 @@ Unsuccessful Response:
 {:message=>"Company must exist and Position title can't be blank", :status=>400}
 ```
 
+Unsuccessful Response(pre-existing application for user):
+```
+{:message=>"Application url You already have an application with this URL", :status=>400}
+```
+
 ### Companies
 
 Get login credentials

app/models/job_application.rb

@@ -6,7 +6,7 @@ class JobApplication < ApplicationRecord
   validates :date_applied, presence: true
   validates :status, presence: true
   validates :job_description, presence: true
-  validates :application_url, presence: true
+  validates :application_url, presence: true, uniqueness: { scope: :user_id, message: "already exists for the user, try making a new application with a new URL." }
   validates :contact_information, presence: true
   validates :company_id, presence: true
 end

spec/models/job_application_spec.rb

@@ -9,6 +9,41 @@
     it { should validate_presence_of(:application_url) }
     it { should validate_presence_of(:contact_information) }
     it { should validate_presence_of(:company_id) }
+
+    subject {
+      user = User.create!(
+        name: "Yolonda Aberdeer", 
+        email: "[email protected]", 
+        password: "nuggetbisket"
+      )
+
+      google = Company.create!(
+        user_id: user.id,
+        name: "Google",
+        website: "google.com",
+        street_address: "1600 Amphitheatre Parkway",
+        city: "Mountain View",
+        state: "CA",
+        zip_code: "94043",
+        notes: "Search engine"
+      )
+
+      JobApplication.create!(
+        position_title: "Jr. CTO",
+        date_applied: "2024-10-31",
+        status: 1,
+        notes: "Fingers crossed!",
+        job_description: "Looking for Turing grad/jr dev to be CTO",
+        application_url: "www.example.com",
+        contact_information: "[email protected]",
+        company_id: google.id,
+        user_id: user.id
+      )
+    }
+
+    it "validates uniqueness of job application for a given user" do
+      expect(subject).to validate_uniqueness_of(:application_url).scoped_to(:user_id).with_message("already exists for the user, try making a new application with a new URL.")
+    end
   end
 
   describe "associations" do

spec/requests/api/v1/job_applications/job_application_create_spec.rb

@@ -32,7 +32,7 @@
         expect(response.status).to eq(200)
 
         jobApp = JSON.parse(response.body, symbolize_names: true)
-        
+
         expect(jobApp[:data][:type]).to eq("job_application")
         expect(jobApp[:data][:id]).to eq(JobApplication.last.id.to_s)
         expect(jobApp[:data][:attributes][:position_title]).to eq(job_application_params[:position_title])
@@ -44,6 +44,20 @@
         expect(jobApp[:data][:attributes][:contact_information]).to eq(job_application_params[:contact_information])
         expect(jobApp[:data][:attributes][:company_id]).to eq(job_application_params[:company_id])      
       end
+      it "Allows 2 unique users to create job applications with the same URL" do
+
+        post "/api/v1/users/#{@user.id}/job_applications", 
+        params: { job_application: job_application_params }
+        expect(response).to be_successful
+        expect(response.status).to eq(200)
+
+        user_2 = User.create!(name: "Daniel Averdaniel", email: "[email protected]", password: "nuggetonnabiscut")
+
+        post "/api/v1/users/#{user_2.id}/job_applications", 
+        params: { job_application: job_application_params }
+        expect(response).to be_successful
+        expect(response.status).to eq(200)
+      end
     end
 
     context "sad path" do
@@ -92,6 +106,23 @@
         expect(json[:message]).to eq("Company must exist and Position title can't be blank")
         expect(json[:status]).to eq(400)
       end
+
+      it "returns a error message if a user tries to create multiple job applications with the same URL" do
+        post "/api/v1/users/#{@user.id}/job_applications", 
+        params: { job_application: job_application_params }
+        expect(response).to be_successful
+        expect(response.status).to eq(200)
+
+        post "/api/v1/users/#{@user.id}/job_applications", 
+        params: { job_application: job_application_params }
+        expect(response).to_not be_successful
+        expect(response.status).to eq(400)
+
+        json = JSON.parse(response.body, symbolize_names: true)
+
+        expect(json[:message]).to eq("Application url already exists for the user, try making a new application with a new URL.")
+        expect(json[:status]).to eq(400)
+      end
     end
   end
 end