-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Michael Hicks #153
base: main
Are you sure you want to change the base?
Michael Hicks #153
Conversation
michaeljhicks
commented
Oct 31, 2021
- [x] I have refactored my `section1` exercises to the best of my ability | ||
- [x] I have refactored my `section2` exercises to the best of my ability | ||
- [x] I have refactored my `section3` exercises to the best of my ability | ||
- [x] I have refactored my `section4` exercises to the best of my ability | ||
|
||
### Time Management Prep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your calendar looks GREAT - from the looks of it, you have a pretty realistic understanding of the demands of Turing. I think you're set up well in that regard.
return built_bear | ||
end | ||
|
||
# Create two new instances of teh build_a_bear method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this, I wouldn't use the term "instance" - I'd save that for when you are creating an object from a Class which is that special type of method.
You can instead say, "call the build_a_bear method" or "invoke the build_a_bear method"!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, good call!
@@ -1,52 +1,80 @@ | |||
# Challenge - See if you can follow the instructions and complete the exercise in under 30 minutes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks awesome here!
|
||
# Reflection | ||
# What parts were most difficult about this exerise? | ||
|
||
# The time limit! Creating a class took lots of review of notes; this was by far the most challenging area. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's 100% ok at this point! You are not a memorization machine; but you're flexing some of these muscles, and when you go deep with these concepts in Mod 1 they won't feel brand new to you.
# What skills do you need to continue to practice before starting Mod 1? | ||
|
||
# I need lots more practice with everything in the wheelhouse that is a class. I have a loose understanding, but the penalty that comes with that is the amount of time it takes to confidently move through it as I'm doing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And building on previous comment - with time and hours and hours of using these things in APPLICATION, you will feel more fluent. You're on the right track.
@@ -1,4 +1,4 @@ | |||
# Add the following methods to this burrito class and | |||
# Add the following methods to this burrito class and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful work! Perfect style and syntax, super readable.
@hometown = hometown | ||
end | ||
|
||
def promotion(new_position) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want method names to be verbs - so maybe instead of promotion, use promote
.
moved_towns
is a bit better, but I'd still recommend changing to move_towns
.
It sounds super nit picky but you always want your code to feel as easy as possible for others to read, and the way we do it is by following those conventions consistently!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense and will do moving forward - thanks!
section4/reflection.md
Outdated
``` | ||
1. What questions do you still have about classes in Ruby? | ||
..* I have a very loose understanding of when to appropriately use `attr_writer`, `attr_accessor`, and `attr_reader` and would love to see some comprehensive examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y'all will dig into that in Mod 1!
Hey there @michaeljhicks ! just had a chance to go over your pre-work and you are officially Turing Ready! I added some comments to a few sections for things to think about as you head into Mod 1. Keep up the focus and hard work, I think you're going to be great. |