Improve log output when failing to load local/remote metadata

tum-esm · Mar 25, 2024 · a07a87a · a07a87a
1 parent a013681
commit a07a87a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/src/retrieval/main.py b/src/retrieval/main.py
@@ -78,21 +78,23 @@ def _graceful_teardown(*args: Any) -> None:
     try:
         em27_metadata_interface = utils.metadata.load_local_em27_metadata_interface(
         )
+        if em27_metadata_interface is not None:
+            print("Found local metadata")
+        else:
+            print(
+                "Did not find local metadata -> fetching metadata from GitHub"
+            )
+            assert config.general.metadata is not None, "Remote metadata not configured"
+            em27_metadata_interface = em27_metadata.load_from_github(
+                github_repository=config.general.metadata.github_repository,
+                access_token=config.general.metadata.access_token,
+            )
+            print("Successfully fetched metadata from GitHub")
     except Exception as e:
         main_logger.exception(e, "Error while loading local metadata")
+        main_logger.archive()
         raise e
 
-    if em27_metadata_interface is not None:
-        print("Found local metadata")
-    else:
-        print("Did not find local metadata -> fetching metadata from GitHub")
-        assert config.general.metadata is not None, "Remote metadata not configured"
-        em27_metadata_interface = em27_metadata.load_from_github(
-            github_repository=config.general.metadata.github_repository,
-            access_token=config.general.metadata.access_token,
-        )
-        print("Successfully fetched metadata from GitHub")
-
     # generate retrieval queue
     retrieval.utils.retrieval_status.RetrievalStatusList.reset()
     job_queue = retrieval.utils.job_queue.RetrievalJobQueue()

diff --git a/src/utils/metadata.py b/src/utils/metadata.py
@@ -20,7 +20,7 @@ def load_local_em27_metadata_interface(
     if any(file_existence):
         if not all(file_existence):
             raise FileNotFoundError(
-                "Found some local metadata files but not all (loca)" +
+                "Found some local metadata files but not all (loca" +
                 "tions.json, sensors.json, campaigns.json). Please " +
                 "add or remove all local metadata files."
             )