Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Debug flag subordinate to any CMAKE_BUILD_TYPE #63

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

thomasgoodfellow
Copy link
Collaborator

In practice the debug flag is being left defaulted to None but was still overriding the build type

In practice the debug flag is being left defaulted to None but was still
overriding the build type
Copy link
Member

@PhilippvK PhilippvK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@PhilippvK PhilippvK merged commit 342df72 into main Apr 19, 2024
4 of 6 checks passed
@thomasgoodfellow thomasgoodfellow deleted the respect_build_type branch April 19, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants