Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Startup detail pages #109

Closed
wants to merge 6 commits into from

Conversation

lankabelgezogen
Copy link
Collaborator

@lankabelgezogen lankabelgezogen commented Jun 24, 2024

Venture has to input their own data, required structure can be found in data/e-lab-startups.json

Example detail page can be found at:
http://localhost:3000/e-lab/startups/airbnb

An overview of the startups can also be embedded like this in e-lab/page.tsx:

<Section className="bg-purple-950 text-white">
  <h2 className="mb-12 bg-gradient-to-r from-yellow-500 to-red-500 bg-clip-text text-center text-3xl font-semibold uppercase tracking-widest text-transparent sm:text-5xl">
    Our Startups
  </h2>
  <div className="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-8">
    {startups.map((startup) => (
      <Link
        key={startup.id}
        href={`/e-lab/startups/${startup.id}`}
        className="bg-purple-900 p-6 rounded-lg hover:bg-purple-800 transition-colors"
      >
        <h3 className="text-2xl font-semibold mb-2">{startup.name}</h3>
        <p className="text-gray-300">{startup.description}</p>
      </Link>
    ))}
  </div>
</Section>

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
website ✅ Ready (Inspect) Visit Preview Jun 28, 2024 3:08pm

@lankabelgezogen lankabelgezogen removed the request for review from simon-hng June 24, 2024 08:16
@lankabelgezogen lankabelgezogen removed their assignment Jun 24, 2024
Copy link
Collaborator

@simon-hng simon-hng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@LaurenzSommerlad
Copy link
Member

Screenshot_20240625_031310_Chrome.jpg

Draft looks great but needs more padding at the top. We could add integration with my new people component once merged to link to founders pages & add social links to contact them

@Cyro292
Copy link
Contributor

Cyro292 commented Jun 28, 2024

image There is some weird bug for 1s when trying to find a startup that dosen't exist. I will try to fix that

Copy link
Member

@LaurenzSommerlad LaurenzSommerlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todos: a few of our startups need to be added before merge into dev as we currently deploy from branch develop. Coding standards of course 😁🫠😅

Furthermore, more design changes and features pending by @zausin33

@Cyro292
Copy link
Contributor

Cyro292 commented Jul 24, 2024

#112 (comment)

Adress this here.

@sofiiadan sofiiadan self-requested a review August 26, 2024 09:33
@sofiiadan
Copy link
Collaborator

Not sure it is an up-to-date branch, so no approval yet.

Copy link
Collaborator

@sofiiadan sofiiadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch does not seem to be up-to-date, so not approval, possibly (if the changes are applied elsewhere) we can close it?

@zausin33 zausin33 closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants