Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/#98 backend member nickname #99

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Refactor/#98 backend member nickname #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
140e629
Merge pull request #97 from tukcomCD2024/Dev-backend
yeonjy Apr 30, 2024
9f9875d
remove: image url update X
yeonjy Apr 30, 2024
df4ee06
test: image url update X
yeonjy Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions backend/core/src/main/java/com/rollthedice/backend/domain/member/dto/MemberUpdateDto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,11 @@
public class MemberUpdateDto {
@Schema(description = "λ³€κ²½ν•  λ‹‰λ„€μž„")
private String nickname;
@Schema(description = "λ³€κ²½ν•  이미지 S3 Url")
private String imageUrl;

public MemberServiceDto toServiceDto(String email) {
return MemberServiceDto.builder()
.email(email)
.nickname(this.nickname)
.imageUrl(this.imageUrl)
.build();
}
}
8 changes: 4 additions & 4 deletions backend/core/src/test/java/com/rollthedice/backend/domain/auth/AuthTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class AuthTest extends LoginTest {
public void accessToken_둜그인_성곡() throws Exception {
// when
final ResultActions perform = mockMvc.perform(post("/members").contentType(MediaType.APPLICATION_JSON)
.content(toRequestBody(new MemberUpdateDto("yeonjy", "imageUrl2")))
.content(toRequestBody(new MemberUpdateDto("yeonjy")))
.header("Authorization", "Bearer " + accessToken));

// then
Expand All @@ -55,7 +55,7 @@ public class AuthTest extends LoginTest {

// when
final ResultActions perform = mockMvc.perform(post("/members").contentType(MediaType.APPLICATION_JSON)
.content(toRequestBody(new MemberUpdateDto("yeonjy", "imageUrl2")))
.content(toRequestBody(new MemberUpdateDto("yeonjy")))
.header("Authorization", "Bearer " + accessToken));

// then
Expand All @@ -78,7 +78,7 @@ public class AuthTest extends LoginTest {

// when
final ResultActions perform = mockMvc.perform(post("/members").contentType(MediaType.APPLICATION_JSON)
.content(toRequestBody(new MemberUpdateDto("yeonjy", "imageUrl2")))
.content(toRequestBody(new MemberUpdateDto("yeonjy")))
.header("Authorization-refresh", "Bearer " + refreshToken)).andDo(print());

// then
Expand All @@ -99,7 +99,7 @@ public class AuthTest extends LoginTest {

// when
final ResultActions perform = mockMvc.perform(post("/members").contentType(MediaType.APPLICATION_JSON)
.content(toRequestBody(new MemberUpdateDto("yeonjy", "imageUrl2")))
.content(toRequestBody(new MemberUpdateDto("yeonjy")))
.header("Authorization-refresh", "Bearer " + refreshToken)).andDo(print());

// then
Expand Down
Loading