Skip to content

Commit

Permalink
Tests: test_microlzma: Add a "FIXME?" about LZMA_FINISH handling
Browse files Browse the repository at this point in the history
  • Loading branch information
Larhzu committed Apr 13, 2024
1 parent 0fe2dfa commit fcbd0d1
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions tests/test_microlzma.c
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,15 @@ test_decode_uncomp_size_wrong(void)

// No error detected, even though all input was consumed and there
// is more room in the output buffer.
//
// FIXME? LZMA_FINISH tells that no more input is coming and
// the MicroLZMA decoder knows the exact compressed size from
// the initialization as well. So should it return LZMA_DATA_ERROR
// on the first call instead of relying on the generic lzma_code()
// logic to eventually get LZMA_BUF_ERROR?
assert_lzma_ret(lzma_code(&strm, LZMA_FINISH), LZMA_OK);
assert_lzma_ret(lzma_code(&strm, LZMA_FINISH), LZMA_OK);
assert_lzma_ret(lzma_code(&strm, LZMA_FINISH), LZMA_BUF_ERROR);

assert_uint_eq(strm.total_out, sizeof(goodbye_world));
assert_array_eq(goodbye_world, output, sizeof(goodbye_world));
Expand Down

0 comments on commit fcbd0d1

Please sign in to comment.