Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Tests: Make the config.h grep patterns Meson compatible
Now the test scripts detect both #define HAVE_DECODER_ARM #define HAVE_DECODER_ARM 1 as support for the ARM filter without confusing it with these: #define HAVE_DECODER_ARM64 #define HAVE_DECODER_ARM64 1 Previously only the ones ending with " 1" were accepted for the macros where this kind of confusion was possible. This should help with Meson support because Meson's built-in features produce config.h entries that are either #define FOO 1 #define FOO 0 or: #define FOO #undef FOO The former method has a benefit that one can use "#if FOO" and -Wundef will catch if a #define is missing (for example, it helps catching typos). But XZ Utils has to use the latter since it has been convenient with Autoconf's default behavior.[*] While it's easy to emulate the Autoconf style (#define FOO 1 vs. no #define at all) in Meson, it results in clumsy code. Thus it's better to change the few places in the tests where this difference matters. [*] While most checks in Autoconf default to the second style above, a few things use the first style (like AC_CHECK_DECLS). The mix of both styles is the most confusing as one has to remember which macro needs #ifdef and which #if. Currently HAVE_VISIBILITY is only such config.h entry that is 1 or 0. It comes unmodified from Gnulib's visibility.m4.
- Loading branch information