Skip to content

Commit

Permalink
ci: don't pin official GH actions via commit, just tag
Browse files Browse the repository at this point in the history
There's no real value in doing it via commit for official GH actions. We
can keep using pinned commits for unofficial actions. It's hassle for no
gain.

Maybe going forward we can limit this further by only being paranoid
for the jobs with any access to tokens.
  • Loading branch information
thesamesam committed Jun 3, 2024
1 parent 556b768 commit 455fabd
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
build_system: [autotools, cmake]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@1d96c772d19495a3b5c517cd2bc0cb401ea0529f #v4.1.3
- uses: actions/[email protected].6

########################
# Install Dependencies #
Expand Down Expand Up @@ -157,7 +157,7 @@ jobs:
run: ./build-aux/ci_build.bash -b ${{ matrix.build_system }} -m "${{ matrix.compiler }}" -d small -p test -n small

# Attempt to upload the test logs as artifacts if any step has failed
- uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 #v4.3.3
- uses: actions/[email protected]
if: ${{ failure() }}
with:
name: ${{ matrix.os }} ${{ matrix.build_system }} Test Logs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/freebsd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
name: Test xz on FreeBSD
steps:
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 #v4
- uses: actions/checkout@v4.1.6
- name: Test in FreeBSD
id: test
uses: vmactions/FreeBSD-vm@f8be330398166d1eb0601f01353839d4052367b2 #v1.0.7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/netbsd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
name: Test xz on NetBSD
steps:
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 #v4
- uses: actions/checkout@v4.1.6
- name: Test in NetBSD
id: test
uses: vmactions/NetBSD-vm@da9ed4d7cd0fb64f330e2342ac5c77ba529b6a11 #v1.0.7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/openbsd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
name: Test xz on OpenBSD
steps:
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 #v4
- uses: actions/checkout@v4.1.6
- name: Test in OpenBSD
id: test
uses: vmactions/OpenBSD-vm@eaa3d3f695a5a52971c23958f6dd4cd3397f959d #v1.0.8
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/solaris.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
name: Test xz on Solaris
steps:
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 #v4
- uses: actions/checkout@v4.1.6
- name: Test in Solaris
id: test
uses: vmactions/solaris-vm@548f790d1bc2b9342a76cbb47ddbb85875605559 #v1.0.2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/windows-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
# text file and will not match the output from xzgrep.
run: git config --global core.autocrlf false

- uses: actions/checkout@1d96c772d19495a3b5c517cd2bc0cb401ea0529f #v4.1.3
- uses: actions/[email protected].6


########################
Expand Down Expand Up @@ -117,7 +117,7 @@ jobs:
###############

# Upload the test logs as artifacts if any step has failed.
- uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 #v4.3.3
- uses: actions/[email protected]
if: ${{ failure() }}
with:
name: ${{ matrix.msys2_env }} ${{ matrix.build_system }} Test Logs
Expand Down

0 comments on commit 455fabd

Please sign in to comment.