Always flush() between write and read #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Messages received after `started` were not being flushed until the very last message (when `not more_body`). Instead, we should always flush() between a write and a read. Without this, we were observing behavior that didn't work for server-sent events: the first message would be delivered immediately, and then all subsequent messages would be delivered all in one go when the last message arrives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages received after
startedwere not being flushed until the very last message (whennot more_body).Instead, we should always flush() between a write and a read.
Without this, we were observing behavior that didn't work for server-sent events: the first message would be delivered immediately, and then all subsequent messages would be delivered all in one go when the last message arrives.
See similar change in GZIpMiddleware at encode/starlette#2753