Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select neutrino #13

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LarsBollmann
Copy link

@LarsBollmann LarsBollmann commented Apr 9, 2024

Add prompt neutrino simulation chains

Copy link
Contributor

@mhuen mhuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that step1 and step 3 can just use imports of existing code. I suggest changing this to reduce duplicated code. Otherwise this is good to go.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you let me know what changed for this icetray version that the file is necessary as opposed to simply importing from from step_1_snowstorm_propagation_py3_v4_2_1_icetray_v1_4_1 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import works for icetray/v1.10.0, so I assume it should also work for v1.8.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff:

< #!/bin/sh /cvmfs/icecube.opensciencegrid.org/py3-v4.3.0/icetray-start
< #METAPROJECT icetray/v1.8.1
---
> #!/bin/sh /cvmfs/icecube.opensciencegrid.org/py3-v4.2.1/icetray-start
> #METAPROJECT icetray/v1.4.1
4a5
> 
8a10
> 
162a165
> 
166a170,171
> 
> 
217a223
>         'ExtraArgumentsToSetupPropagators': dict(),
431c437,438
<             UseOnlyDeviceNumber=cfg['UseOnlyDeviceNumber']
---
>             UseOnlyDeviceNumber=cfg['UseOnlyDeviceNumber'],
>             **cfg["ExtraArgumentsToSetupPropagators"]
496a504
>         # Execute Tray
594c602
<     main()
\ No newline at end of file
---
>     main()

Seems safe to replace with the import as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above. Import from step_3_pass2_L1_py3_v4_1_0 works for v1.10.0, so I suppose it should also for 1.8.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps one could check the diffs between this file and the step_3_pass2_L1_py3_v4_1_0 one

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff:

< #!/bin/sh /cvmfs/icecube.opensciencegrid.org/py3-v4.3.0/icetray-start
< #METAPROJECT icetray/v1.8.1
---
> #!/bin/sh /cvmfs/icecube.opensciencegrid.org/py3-v4.1.0/icetray-start
> #METAPROJECT /data/user/mhuennefeld/software/icecube/py3-v4.1.0/combo_V01-00-00/build
76a77,79
> 
>     start_time = time.time()
> 
192a196
>         'DOMDeadTimesMC',
330a335,337
>     end_time = time.time()
>     print("That took "+str(end_time - start_time)+" seconds.")
> 
333c340
<     main()
\ No newline at end of file
---
>     main()

Seems like this is safe to replace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants