Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements by multithreading #24

Closed

Conversation

dominikmaeckel
Copy link
Member

No description provided.

@dominikmaeckel dominikmaeckel self-assigned this Dec 8, 2023
@dominikmaeckel dominikmaeckel linked an issue Dec 8, 2023 that may be closed by this pull request
@dominikmaeckel dominikmaeckel added this to the v0.3 milestone Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 363 lines in your changes are missing coverage. Please review.

Comparison is base (dd56637) 27.98% compared to head (a49e6af) 29.79%.
Report is 3 commits behind head on main.

Files Patch % Lines
...tools/aqua/stars/importer/carla/CarlaDataLoader.kt 0.00% 105 Missing ⚠️
...ools/aqua/stars/core/evaluation/EvaluationState.kt 0.00% 47 Missing ⚠️
.../tools/aqua/stars/core/evaluation/TSCEvaluation.kt 38.35% 42 Missing and 3 partials ⚠️
...qua/stars/core/metric/metrics/EvaluationMetrics.kt 41.86% 24 Missing and 1 partial ⚠️
...ric/metrics/postEvaluation/FailedMonitorsMetric.kt 0.00% 23 Missing ⚠️
...evaluation/ValidTSCInstancesPerProjectionMetric.kt 0.00% 20 Missing ⚠️
...MissingPredicateCombinationsPerProjectionMetric.kt 0.00% 18 Missing ⚠️
...aluation/InvalidTSCInstancesPerProjectionMetric.kt 0.00% 15 Missing ⚠️
...valuation/MissedTSCInstancesPerProjectionMetric.kt 0.00% 14 Missing ⚠️
...s/evaluation/SegmentDurationPerIdentifierMetric.kt 9.09% 10 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   27.98%   29.79%   +1.80%     
==========================================
  Files         101      112      +11     
  Lines        2176     2430     +254     
  Branches      274      308      +34     
==========================================
+ Hits          609      724     +115     
- Misses       1542     1679     +137     
- Partials       25       27       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dominikmaeckel dominikmaeckel added the performance Performance improvement label Dec 8, 2023
@dominikmaeckel dominikmaeckel marked this pull request as ready for review December 11, 2023 07:01
@dominikmaeckel dominikmaeckel enabled auto-merge (squash) December 11, 2023 07:03
@dominikmaeckel dominikmaeckel force-pushed the 23-performance-improvements-by-multithreading branch from a5a4931 to 7f831df Compare January 15, 2024 08:43
@dominikmaeckel dominikmaeckel enabled auto-merge (squash) January 15, 2024 08:56
@dominikmaeckel dominikmaeckel marked this pull request as draft February 7, 2024 12:07
auto-merge was automatically disabled February 7, 2024 12:07

Pull request was converted to draft

@dominikmaeckel dominikmaeckel marked this pull request as ready for review February 12, 2024 16:15
@dominikmaeckel dominikmaeckel marked this pull request as draft February 12, 2024 16:15
@dominikmaeckel dominikmaeckel force-pushed the 23-performance-improvements-by-multithreading branch from 2d14bf1 to 7f831df Compare February 12, 2024 16:25
…ements-by-multithreading

# Conflicts:
#	buildSrc/src/main/kotlin/tools.aqua.stars.kotlin-conventions.gradle.kts
@dominikmaeckel dominikmaeckel marked this pull request as ready for review February 13, 2024 08:57
@dominikmaeckel dominikmaeckel marked this pull request as draft May 2, 2024 07:43
@dominikmaeckel dominikmaeckel removed this from the v0.3 milestone May 2, 2024
@tillschallau tillschallau added this to the Future work milestone May 13, 2024
@dominikmaeckel
Copy link
Member Author

Complete rework needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance improvements by multithreading
2 participants