chore: improve code in openaccess

tu-graz-library · Jan 7, 2025 · 7b69654 · 7b69654
1 parent 1100cde
commit 7b69654
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/invenio_workflows_tugraz/openaccess/utils.py b/invenio_workflows_tugraz/openaccess/utils.py
@@ -36,7 +36,7 @@ def license_type(electronic_version: dict) -> str:
         return False
 
 
-def extract_files(pure_record) -> URL:
+def extract_files(pure_record: dict) -> URL:
     """Extract file url."""
 
     def condition(item: dict) -> bool:
@@ -55,7 +55,8 @@ def condition(item: dict) -> bool:
             continue
 
     if len(files) == 0:
-        raise PureRuntimeError(pure_record)
+        msg = f"record: {pure_record["uuid"]} doesn't provide downloadable files"
+        raise RuntimeError(msg)
 
     return files
 

diff --git a/invenio_workflows_tugraz/openaccess/workflow.py b/invenio_workflows_tugraz/openaccess/workflow.py
@@ -33,7 +33,7 @@
 def openaccess_filter() -> dict:
     """Openaccess filter."""
     return {
-        "keywordUris": ["dk/atira/pure/researchoutput/keywords/export2repo/validated"]
+        "keywordUris": ["dk/atira/pure/researchoutput/keywords/export2repo/validated"],
     }
 
 
@@ -53,9 +53,7 @@ def import_func(
     try:
         pure_record = pure_service.get_metadata(identity, pure_id)
         files = extract_files(pure_record)
-        file_paths = []
-        for file_ in files:
-            file_paths.append(pure_service.download_file(identity, file_))
+        file_paths = [pure_service.download_file(identity, file_) for file_ in files]
     except (PureRESTError, PureRuntimeError) as error:
         raise RuntimeError(str(error)) from error