Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sentry support #47

Merged
merged 9 commits into from
Feb 13, 2024
Merged

add sentry support #47

merged 9 commits into from
Feb 13, 2024

Conversation

lwalejko
Copy link
Collaborator

@lwalejko lwalejko commented Feb 6, 2024

Closes #35

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a6a050) 92.27% compared to head (8ee0f66) 92.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel      #47      +/-   ##
==========================================
+ Coverage   92.27%   92.61%   +0.34%     
==========================================
  Files           7        7              
  Lines         427      447      +20     
==========================================
+ Hits          394      414      +20     
  Misses         33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kamilsi
kamilsi previously requested changes Feb 6, 2024
Copy link
Contributor

@kamilsi kamilsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny request: maybe let's make sentry setup internal?

R/run-api.R Outdated Show resolved Hide resolved
@lwalejko lwalejko requested review from JagGlo and kamilsi February 13, 2024 09:58
@lwalejko lwalejko dismissed kamilsi’s stale review February 13, 2024 10:00

change request accepted - dismissing due to reviewer unavailability

Copy link
Contributor

@JagGlo JagGlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving; upcoming code review by @kamilsi

@JagGlo JagGlo merged commit 9337ed5 into devel Feb 13, 2024
5 checks passed
@JagGlo JagGlo deleted the sentry branch February 13, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants