Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette: minimisation vs block and simple randomization #39

Merged
merged 18 commits into from
Feb 9, 2024

Conversation

kamilsi
Copy link
Contributor

@kamilsi kamilsi commented Jan 25, 2024

This closes #33

@kamilsi kamilsi requested a review from JagGlo January 25, 2024 16:39
vignettes/simulations.Rmd Outdated Show resolved Hide resolved
vignettes/simulations.Rmd Outdated Show resolved Hide resolved
vignettes/simulations.Rmd Outdated Show resolved Hide resolved
Copy link
Contributor Author

@kamilsi kamilsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this document, Ola! You've done a fantastic job in laying out the details of the simulation. I've included a few suggestions to further refine and clarify some points. Your effort in putting this together really shows, and these minor adjustments are just to enhance what is already a solid piece of work. Keep up the great effort!

vignettes/renv.lock Outdated Show resolved Hide resolved
vignettes/simulations.Rmd Outdated Show resolved Hide resolved
vignettes/simulations.Rmd Outdated Show resolved Hide resolved
renv.lock Outdated Show resolved Hide resolved
vignettes/simulations.Rmd Outdated Show resolved Hide resolved
vignettes/simulations.Rmd Outdated Show resolved Hide resolved
vignettes/simulations.Rmd Outdated Show resolved Hide resolved
vignettes/simulations.Rmd Outdated Show resolved Hide resolved
vignettes/simulations.Rmd Outdated Show resolved Hide resolved
vignettes/simulations.Rmd Outdated Show resolved Hide resolved
Copy link
Contributor

@JagGlo JagGlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Ola! This chunk of text you prepared is really impressive!
Plus: Vignette has now became an article.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b56e5a) 92.27% compared to head (52dd63e) 92.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel      #39   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files           7        7           
  Lines         427      427           
=======================================
  Hits          394      394           
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lwalejko lwalejko merged commit 9b5f493 into devel Feb 9, 2024
5 checks passed
@salatak salatak linked an issue Mar 1, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants