Changes resulting from code review + fix for catching errors

ttscience · Feb 19, 2024 · d76250a · d76250a
1 parent 7358b3c
commit d76250a
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/R/api_get_study.R b/R/api_get_study.R
@@ -1,7 +1,6 @@
 api_get_study <- function(res, req) {
   db_connection_pool <- get("db_connection_pool")
 
-
   study_list <-
     dplyr::tbl(db_connection_pool, "study") |>
     dplyr::select(study_id = id, identifier, name, method, last_edited = timestamp) |>
@@ -25,8 +24,7 @@ api_get_study_records <- function(study_id, req, res) {
   if (!is_study) {
     res$status <- 404
     return(list(
-      error = "Study not found",
-      details = r$error
+      error = "Study not found"
     ))
   }
 
@@ -82,7 +80,7 @@ api_get_study_records <- function(study_id, req, res) {
     tidyr::pivot_wider(names_from = arm_name, values_from = ratio) |>
     as.list()
 
-  study_list <-
+  study_elements <-
     list(
       strata = strata,
       arms = arms
@@ -95,7 +93,7 @@ api_get_study_records <- function(study_id, req, res) {
       jsonlite::fromJSON() |>
       purrr::flatten_dfr() |>
       dplyr::select(p, method),
-    study_list
+    study_elements
   )
 
   return(study_list)