Fixed bug in sarracen.disc.azimuthal_average #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding this PR! You'll notice a red x on your PR that the Lint action has failed. We've recently linted the code base to adhere to Python style guides, many of which are onerous, but we follow them to hopefully curb future problems and maintain readability. For this PR, the lint error is as follows:
Can you add a new commit to this PR that edits the docstring so that each line is less than 80 characters? That will fix this lint error. |
ttricco
approved these changes
Oct 31, 2024
|
Vasu, thank you for helping to improve Sarracen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where sarracen.disc.azimuthal_average took the sum of the target in a radial bin rather than its average.