Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for esp32s3 #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

offspring
Copy link

@offspring offspring commented Aug 26, 2024

Verified using
esp32-s3-tiny
esp32-s3-dev-kit-n8r8
sn65hvd230-can-board

Sorry Timo i have to recreate #28 from fork / branch so it is easier to use from Platform io as https://github.com/offspring/NMEA2000_esp32.git#add-esp32s3 in lib deps section

@unxs0
Copy link

unxs0 commented Aug 26, 2024

So, to try this out, all I have to do is edit the platformio.ini file, as you mention above? Thanks.

@offspring
Copy link
Author

So, to try this out, all I have to do is edit the platformio.ini file, as you mention above? Thanks.

You may need a board definition platformio_boards

@offspring
Copy link
Author

and platform.ini

[env]
platform = espressif32
framework = arduino

lib_deps =
  ttlappalainen/NMEA2000-library
  https://github.com/offspring/NMEA2000_esp32.git#add-esp32s3

[env:esp32-s3-fh4r2]
board = esp32-s3-fh4r2

[env:esp32-s3-dev-kit-n8r8]
board = esp32-s3-dev-kit-n8r8

@ttlappalainen
Copy link
Owner

This may be problematic:
#if ARDUINO >= 100
#include <Arduino.h>
#endif

If one does not use arduino environment, it will fail. Do you really need to include Arduino.h?

@offspring
Copy link
Author

#if ARDUINO >= 100
#include <Arduino.h>
#endif

No Arduino no issue that is why you have a guard

#if ARDUINO >= 100
#include <Arduino.h>
#endif

And all changes are guarded by specific defines too. it will be possible to do similar defines for non Arduino systems

@unxs0
Copy link

unxs0 commented Aug 31, 2024

Some newbies, like me, may find this quick note useful.

The following compiles clean using my custom dev board, from simple platformio/pio command line ubuntu dev env:

pio command

$ /usr/bin/pio run --environment base

platform.io file:

[env:base]
platform = espressif32
framework = arduino
board = esp32-s3-devkitc-1
monitor_speed = 115200
lib_deps =
  https://github.com/ttlappalainen/NMEA2000
  https://github.com/offspring/NMEA2000_esp32

Of course with valid src files. See pio project --help

TODO:
Will connect esp32s3 to my known to work well n2k interface (ISO1050 w/filter and static protection diodes) and will get back with results.

@offspring
Copy link
Author

IMG20240828232721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants