#8-1 떡국 단순 생성 API #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
코드 리뷰 요청합니다 🙆 @mungmnb777 |
@AuthenticationPrincipal을 활용하셔도 되고, SecurityContext를 활용하셔도 됩니다. |
mungmnb777
reviewed
Jan 21, 2024
build.gradle
Outdated
| @@ -24,6 +24,7 @@ repositories { | |||
| dependencies { | |||
| implementation 'org.springframework.boot:spring-boot-starter-data-jpa' | |||
| implementation 'org.springframework.boot:spring-boot-starter-security' | |||
| implementation 'org.springframework.boot:spring-boot-starter-validation' | |||
There was a problem hiding this comment.
validation 의존성을 저도 추가해놔서 빼도 될 것 같네용
|
|
||
| public CreateTteokgukResponse createTteokguk(CreateTteokgukRequest request) { | ||
| Member member = memberRepository.findById(request.memberId()) | ||
| .orElseThrow(() -> BusinessException.of(MEMBER_NOT_FOUND)); |
There was a problem hiding this comment.
요청 바디로 획득한 유저의 정보보다, SecurityContext의 유저 정보를 이용해 생성하는건 어떤가요?
위의 로직은 유저가 다른 유저의 떡국을 생성하는 일이 생길 수 있겠네요
|
성공적으로 Merge 되었습니다. Shout out to @mungmnb777 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue ticket link and number
Describe changes
Notification for Reviewer