Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow variable case for Doodson number formalisms #361

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

tsutterley
Copy link
Owner

feat: added property for Extended Doodson numbers in constituents
fix: use Love numbers for long-period tides when inferring (won't affect tilt factors)

feat: added property for Extended Doodson numbers
fix: use Love numbers for long-period tides when inferring (won't affect tilt factors)
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 70.85%. Comparing base (3d34f83) to head (da01d65).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pyTMD/io/constituents.py 20.00% 8 Missing ⚠️
pyTMD/arguments.py 50.00% 1 Missing and 2 partials ⚠️
pyTMD/io/model.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   70.90%   70.85%   -0.05%     
==========================================
  Files          41       41              
  Lines       10391    10401      +10     
  Branches     1130     1131       +1     
==========================================
+ Hits         7368     7370       +2     
- Misses       2562     2570       +8     
  Partials      461      461              
Flag Coverage Δ
unittests 70.85% <42.85%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsutterley tsutterley merged commit 74ce25f into main Nov 7, 2024
3 of 5 checks passed
@tsutterley tsutterley deleted the dev branch November 7, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant