-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding GOT5.5 and GOT download program #316
Conversation
* refactor: renamed format for `ATLAS` to `ATLAS-compact` * refactor: renamed format for `netcdf` to `ATLAS-netcdf` * refactor: renamed format for `FES` to `FES-netcdf` and added `FES-ascii` * refactor: renamed format for `GOT` to `GOT-ascii` and added `GOT-netcdf` * feat: add JSON definition files for GOT5.5D and GOT5.6
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
==========================================
+ Coverage 69.17% 69.36% +0.18%
==========================================
Files 39 39
Lines 9365 10470 +1105
Branches 1322 1448 +126
==========================================
+ Hits 6478 7262 +784
- Misses 2467 2731 +264
- Partials 420 477 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I didn't realise there were new versions of GOT available! Have you come across any documentation for them? I can see the files here but not really any extra details... |
Great question. I don't have on hand any additional documentation as I think Richard is writing it up. I know they are higher resolution and with more solved constituents. They have better treatment of some confounding effects (like atmospheric tides), and in the case of GOT5.6 include degree-3 components. |
Turns out there's a readme with a bit of extra info in the zip file - thanks @vnewey!
|
fix: revert OTIS crop change and assume bounds are projected
fix: small differences for OTIS `o1`
ATLAS
toATLAS-compact
netcdf
toATLAS-netcdf
FES
toFES-netcdf
and addedFES-ascii
GOT
toGOT-ascii
and addedGOT-netcdf