Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding GOT5.5 and GOT download program #316

Merged
merged 11 commits into from
Aug 8, 2024
Merged

feat: adding GOT5.5 and GOT download program #316

merged 11 commits into from
Aug 8, 2024

Conversation

tsutterley
Copy link
Owner

  • refactor: renamed format for ATLAS to ATLAS-compact
  • refactor: renamed format for netcdf to ATLAS-netcdf
  • refactor: renamed format for FES to FES-netcdf and added FES-ascii
  • refactor: renamed format for GOT to GOT-ascii and added GOT-netcdf
  • feat: add JSON definition files for GOT5.5D and GOT5.6

* refactor: renamed format for `ATLAS` to `ATLAS-compact`
* refactor: renamed format for `netcdf` to `ATLAS-netcdf`
* refactor: renamed format for `FES` to `FES-netcdf` and added `FES-ascii`
* refactor: renamed format for `GOT` to `GOT-ascii` and added `GOT-netcdf`
* feat: add JSON definition files for GOT5.5D and GOT5.6
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 77.92683% with 362 lines in your changes missing coverage. Please review.

Project coverage is 69.36%. Comparing base (3d1d88a) to head (6c99005).

Files Patch % Lines
pyTMD/arguments.py 69.52% 268 Missing and 62 partials ⚠️
pyTMD/io/model.py 85.71% 6 Missing and 7 partials ⚠️
pyTMD/compute.py 33.33% 3 Missing and 3 partials ⚠️
test/test_arguments.py 98.80% 0 Missing and 5 partials ⚠️
pyTMD/check_points.py 50.00% 0 Missing and 2 partials ⚠️
pyTMD/io/constituents.py 83.33% 1 Missing and 1 partial ⚠️
pyTMD/io/GOT.py 50.00% 1 Missing ⚠️
pyTMD/io/OTIS.py 0.00% 1 Missing ⚠️
pyTMD/tools.py 0.00% 1 Missing ⚠️
test/test_atlas_read.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   69.17%   69.36%   +0.18%     
==========================================
  Files          39       39              
  Lines        9365    10470    +1105     
  Branches     1322     1448     +126     
==========================================
+ Hits         6478     7262     +784     
- Misses       2467     2731     +264     
- Partials      420      477      +57     
Flag Coverage Δ
unittests 69.36% <77.92%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robbibt
Copy link
Contributor

robbibt commented Jul 25, 2024

I didn't realise there were new versions of GOT available! Have you come across any documentation for them? I can see the files here but not really any extra details...
https://earth.gsfc.nasa.gov/geo/data/ocean-tide-models

@tsutterley
Copy link
Owner Author

Great question. I don't have on hand any additional documentation as I think Richard is writing it up. I know they are higher resolution and with more solved constituents. They have better treatment of some confounding effects (like atmospheric tides), and in the case of GOT5.6 include degree-3 components.

@robbibt
Copy link
Contributor

robbibt commented Jul 25, 2024

Turns out there's a readme with a bit of extra info in the zip file - thanks @vnewey!

The ocean tide atlas available at this site, called GOT5.6, is
the latest solution in a series beginning with the work described in:

E J O Schrama and R Ray, Journal of Geophysical Research, v.99, p 24799, 1994.
and
R Ray, A global ocean tide model from Topex/Poseidon altimetry: GOT99.2,
   NASA Tech Memo 209478, 58 pages, Sept. 1999.
and
R Ray, Science Advances, 2020. DOI: 10.1126/sciadv.abd4744


GOT5.6 is a supplement to GOT5.5, which provides four additional
constituents, all generated by the third-degree terms of the astronomical
tide potential.  (It is considered a different "model" only because
some users have hard-coded the constituents of GOT5.5.)
You can combine the GOT5.5 and GOT5.6 files and call it GOT5.6.

The data for these four small constituents are defined only in the ±66°
latitude band covered by T/P and Jason altimetry (but tapered to
zero at higher latitudes).  Attempts to derive these tides from
non-T/P-J data have (so far) produced mostly noise.

The nomenclature here uses a prime(') to distinguish 3rd degree from
2nd degree tides. (The 2020 paper uses a leading "3" superscript.)
This isn't needed for M3, since there is no 2nd-deg M3 tide.

R D Ray, Goddard Space Flight Center                       July 2024
[email protected]

@tsutterley tsutterley merged commit 4275e2d into main Aug 8, 2024
4 checks passed
@tsutterley tsutterley deleted the dev branch August 8, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants