Compatible-features inspired overhaul of FA #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses #45 |
|
And #41 |
This change makes things a little simpler and justifies the methods a little more (as far as I'm concerned). In future we will want to improve the linalg code and probably just use components from external crates. The problem we have is that most existing frameworks don't support simple versions sparse features or gradient matrices. My view is to leave it like this for now (i.e. messy AF) and then rewrite it all to make liberal use of GATs when they are stable. This would allow us to hide _all_ the underlying code and just implement lightweight interfaces as with the Entry approach taken in the std library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a ridiculous amount of changes and will take too long to explain in detail. It's taken a long time to get here but the framework is much more usable now. There are still a lot of things that need refinement (such as the gradients module in fa) but on the whole it's a major improvement.