Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This statement in the docs was wrong
as demonstrated by:
Note that
sim_ancestry
has created a node att=0.79
, before the age of the oldest root (which is at 1.0).However, doing
mts = msprime.sim_ancestry(initial_state=ts, population_size=1, start_time=1.0
would start the simulation off at1.0
. We could add something to the docs saying this, but it's kinda a can of worms - for instance, the bit on recapitation says that "you must have all the input roots"; you might think it's okay to just specifystart_time
instead, but that's not right because you miss the recombinations that have happened to those root branches.