-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Spring ViewComponent and remove ViewAction #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplified paths in settings.gradle.kts for increased maintainability - Streamlined the ThymeleafViewComponentAutoConfiguration by using ViewComponentProperties - Updated README.md to reflect these changes - Added a new file, ViewComponentProperties.kt, to contain configuration properties
- Removed ActionViewComponent and NestedActionViewComponent links from index view in Thymeleaf, KTE, and Java examples. - Updated the external project path in the 'Run all example tests' configuration.
…tions - Update the versions in the build scripts to use 0.8.0-SNAPSHOT - Clean up configurations by removing unnecessary annotation processor paths, includes, and properties - Comment out viewComponentRoot in the application.properties file - Remove unnecessary implementation dependencies in the dependencies blocks - Update README.md, removing outdated instructions and providing updated version information - Modify ViewComponent properties in JteConfiguration - Remove ViewComponent reference retrieval function in JteConfiguration - Remove unnecessary test dependency in Thymeleaf-Java - Remove unnecessary annotation processor paths - Update versions in xml files to match snapshot version - Modify TemplateEngine and TemplateResolver Beans in ThymeleafViewComponentAutoConfiguration
tschuehly
force-pushed
the
v0.7.5-SNAPSHOT
branch
from
June 3, 2024 20:39
303a24e
to
f9616b9
Compare
In this commit, we have: - Updated the project version reference from a snapshot version to an official release version across multiple files - Adjusted artifact dependencies to point to the correct 0.8.0 version instead of the snapshot - Updated Maven dependency versions in README.md - Adjusted version properties in pom.xml for JTE and Thymeleaf examples - Fixed some minor formatting issues in README.md's XML snippets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to remove the ViewAction concept. Thereby making the annotation processor unneeded.
The goal is to create a functional approach for HTMX Endpoints described here in an extension at a later date: wimdeblauwe/htmx-spring-boot#104
Also instead of using a JteCompiler, the JTE Spring Boot starter will be configured to do that.