Merge pull request #102 from ulvesked/master

Escape Locale Strings before adding to array
tschoffelen · Jul 22, 2020 · 873113d · 873113d
2 parents b4091de + 015ba2a
commit 873113d
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/src/PKPass.php b/src/PKPass.php
@@ -237,7 +237,7 @@ public function addLocaleStrings($language, $strings = [])
         }
         $dictionary = "";
         foreach($strings as $key => $value) {
-            $dictionary .= '"'. $key .'" = "'. $value .'";'. PHP_EOL;
+            $dictionary .= '"'. $this->escapeLocaleString($key) .'" = "'. $this->escapeLocaleString($value) .'";'. PHP_EOL;
         }
         $this->locales[$language] = $dictionary;
 
@@ -665,4 +665,17 @@ protected function clean()
 
         return true;
     }
+
+    protected static $escapeChars = [
+        "\n" => "\\n",
+        "\r" => "\\r",
+        "\"" => "\\\"",
+        "\\" => "\\\\"
+    ];
+    /**
+     * Escapes strings for use in locale files
+     */
+    protected function escapeLocaleString($string) {
+        return strtr($string, self::$escapeChars);
+    }
 }