Feature/GitHub webhooks instances #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 23, 2018 10:14
Some uses of webhooks require dynamic keys, such as adding new keys for new users or repositories. This change allows dynamic keys to look at the result (ex: repository or username) before returning a key for use in verification. N.B. the API changes since we now have: Another type variable on GitHubKey'. GitHubKey now wraps a function that takes an extra argument. Helper functions of `dynamicKey` and `repositoryKey` exist. Helper class of `HasRepository` exists with bare-bones instances.
|
This PR looks good to me. Just get it to pass travis and I'll merge it. |
|
It appears I finally re-learned stack fields. Let me know if you'd like any other changes. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in PR #7 we might want to incorporate github-webhooks (package) and instances for HasRepository. That's this PR.
I did the cheap thing and made one instances of the
HasRepositoryclass on a polymorphic newtype wrapper and re-used github-webhooks'EventHasRepoclass. The advantage here is lower maintenance - we didn't need to write and maintain N instances. The downside is the user needs to unwrap the Events (but the JSON decoding should be handled). It would be nice to just re-useEventHasRepoand not have our own class but that would assume all users stick with the github-webhooks types which seems overly-restrictive.