Raise interpretable error when no BOLD runs survive minimum-time thre…

…shold (PennLINC#1048)
tsalo · Feb 16, 2024 · a23910d · a23910d
1 parent 1d7bce2
commit a23910d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/xcp_d/interfaces/report_core.py b/xcp_d/interfaces/report_core.py
@@ -142,17 +142,27 @@ def generate_reports(
     else:
         LOGGER.info("Generating executive summary.")
         for subject_label in subject_list:
-            brainplotfile = glob.glob(
+            brainplotfiles = glob.glob(
                 os.path.join(
                     output_dir,
                     f"xcp_d/sub-{subject_label}",
                     "figures/*_bold.svg",
                 ),
-            )[0]
+            )
+            if not brainplotfiles:
+                LOGGER.warning(
+                    "No postprocessing BOLD figures found for subject %s.",
+                    subject_label,
+                )
+                session_id = None
+            else:
+                brainplotfile = brainplotfiles[0]
+                session_id = get_entity(brainplotfile, "ses")
+
             exsumm = ExecutiveSummary(
                 xcpd_path=os.path.join(output_dir, "xcp_d"),
                 subject_id=subject_label,
-                session_id=get_entity(brainplotfile, "ses"),
+                session_id=session_id,
             )
             exsumm.collect_inputs()
             exsumm.generate_report()

diff --git a/xcp_d/workflows/base.py b/xcp_d/workflows/base.py
@@ -808,6 +808,12 @@ def init_subject_wf(
             for io_name, node in merge_dict.items():
                 workflow.connect([(node, concatenate_data_wf, [("out", f"inputnode.{io_name}")])])
 
+    if run_counter == 0:
+        raise RuntimeError(
+            f"No runs survived high-motion outlier scrubbing for subject {subject_id}. "
+            "Quitting workflow."
+        )
+
     workflow.connect([
         (summary, ds_report_summary, [("out_report", "in_file")]),
         (about, ds_report_about, [("out_report", "in_file")]),