Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GERMAN Translation #501

Merged
merged 8 commits into from
Feb 9, 2021
Merged

GERMAN Translation #501

merged 8 commits into from
Feb 9, 2021

Conversation

MakiWolf
Copy link
Contributor

@MakiWolf MakiWolf commented Feb 9, 2021

Translate the new strings from #200 also in GERMAN

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #501 (28ea9cf) into master (ae2dd8e) will increase coverage by 36.74%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #501       +/-   ##
===========================================
+ Coverage   47.80%   84.55%   +36.74%     
===========================================
  Files          32       32               
  Lines        1822     1845       +23     
  Branches      174      254       +80     
===========================================
+ Hits          871     1560      +689     
+ Misses        908      120      -788     
- Partials       43      165      +122     
Flag Coverage Δ
android 83.76% <ø> (+39.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hub/ashutoshgngwr/noice/cast/CastVolumeProvider.kt 85.71% <0.00%> (-14.29%) ⬇️
...noice/cast/player/strategy/CastPlaybackStrategy.kt 60.00% <0.00%> (-3.16%) ⬇️
...m/github/ashutoshgngwr/noice/MediaPlayerService.kt 84.82% <0.00%> (-2.10%) ⬇️
...ice/sound/player/strategy/LocalPlaybackStrategy.kt 64.81% <0.00%> (-1.23%) ⬇️
.../github/ashutoshgngwr/noice/sound/player/Player.kt 92.10% <0.00%> (+0.21%) ⬆️
.../ashutoshgngwr/noice/sound/player/PlayerManager.kt 84.43% <0.00%> (+0.79%) ⬆️
...java/com/github/ashutoshgngwr/noice/sound/Sound.kt 99.62% <0.00%> (+1.12%) ⬆️
...ithub/ashutoshgngwr/noice/widget/DurationPicker.kt 81.81% <0.00%> (+3.03%) ⬆️
...ava/com/github/ashutoshgngwr/noice/sound/Preset.kt 91.07% <0.00%> (+7.43%) ⬆️
...toshgngwr/noice/cast/CastSessionManagerListener.kt 10.00% <0.00%> (+10.00%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2dd8e...28ea9cf. Read the comment docs.

Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Thank you for your contributions!

@ashutoshgngwr ashutoshgngwr merged commit 128ab10 into trynoice:master Feb 9, 2021
@MakiWolf MakiWolf deleted the translation branch February 14, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants