Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translations #341

Merged
merged 2 commits into from
Sep 22, 2020
Merged

German translations #341

merged 2 commits into from
Sep 22, 2020

Conversation

schubeda
Copy link
Contributor

Changes

Small corrections for German translations

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

  • Fixes #0
  • Connects #0

"Brown" is the name of a person, so it can't be translated like the colour "brown".

Plus some minor fixes.
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #341 into master will decrease coverage by 14.85%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #341       +/-   ##
=============================================
- Coverage     86.85%   71.99%   -14.86%     
- Complexity        0      136      +136     
=============================================
  Files            30       24        -6     
  Lines          1613     1532       -81     
  Branches        178      174        -4     
=============================================
- Hits           1401     1103      -298     
- Misses          114      356      +242     
+ Partials         98       73       -25     
Flag Coverage Δ Complexity Δ
#android 69.89% <ø> (-16.25%) 136.00 <ø> (+136.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...thub/ashutoshgngwr/noice/fragment/AboutFragment.kt 99.10% <ø> (+0.02%) 9.00 <0.00> (+9.00)
.../github/ashutoshgngwr/noice/sound/player/Player.kt 7.89% <0.00%> (-84.22%) 1.00% <0.00%> (+1.00%) ⬇️
...ice/sound/player/strategy/LocalPlaybackStrategy.kt 0.00% <0.00%> (-64.82%) 0.00% <0.00%> (ø%)
.../ashutoshgngwr/noice/sound/player/PlayerManager.kt 24.20% <0.00%> (-60.51%) 3.00% <0.00%> (+3.00%) ⬇️
...m/github/ashutoshgngwr/noice/MediaPlayerService.kt 31.48% <0.00%> (-54.63%) 5.00% <0.00%> (+5.00%) ⬇️
...nd/player/strategy/LocalPlaybackStrategyFactory.kt 50.00% <0.00%> (-50.00%) 1.00% <0.00%> (+1.00%) ⬇️
...m/github/ashutoshgngwr/noice/WakeUpTimerManager.kt 38.88% <0.00%> (-36.12%) 4.00% <0.00%> (+4.00%) ⬇️
...ithub/ashutoshgngwr/noice/widget/DurationPicker.kt 42.30% <0.00%> (-34.62%) 3.00% <0.00%> (+3.00%) ⬇️
...ava/com/github/ashutoshgngwr/noice/sound/Preset.kt 72.72% <0.00%> (-20.46%) 6.00% <0.00%> (+6.00%) ⬇️
...hub/ashutoshgngwr/noice/widget/MarkdownTextView.kt 33.33% <0.00%> (-11.12%) 2.00% <0.00%> (+2.00%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3db087...4f7be1a. Read the comment docs.

@ashutoshgngwr
Copy link
Member

@schubeda

Thank you for your contribution! PS, can you also translate the missing strings? Please take a look at #200.

Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @schubeda. I am merging this. If you want to act on my last comment, feel free to open up a new PR. :)

@ashutoshgngwr ashutoshgngwr merged commit 90eb235 into trynoice:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants