feat(core): add fallback values per flag (#63)

tryabby · Sep 11, 2023 · ed5c7ab · ed5c7ab · vercel · Sep 11, 2023
1 parent b80054c
commit ed5c7ab
Show file tree

Hide file tree

Showing 18 changed files with 112 additions and 11 deletions.
diff --git a/apps/angular-example/CHANGELOG.md b/apps/angular-example/CHANGELOG.md
@@ -1,5 +1,13 @@
 # angular-example
 
+## 0.0.11
+
+### Patch Changes
+
+- Updated dependencies
+  - @tryabby/angular@2.0.1
+  - @tryabby/devtools@5.0.0
+
 ## 0.0.10
 
 ### Patch Changes

diff --git a/apps/angular-example/package.json b/apps/angular-example/package.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-example",
-  "version": "0.0.10",
+  "version": "0.0.11",
   "private": true,
   "scripts": {
     "ng": "ng",

diff --git a/apps/web/CHANGELOG.md b/apps/web/CHANGELOG.md
@@ -1,5 +1,14 @@
 # web
 
+## 0.2.29
+
+### Patch Changes
+
+- Updated dependencies
+  - @tryabby/core@5.0.1
+  - @tryabby/next@5.0.1
+  - @tryabby/devtools@5.0.0
+
 ## 0.2.28
 
 ### Patch Changes

diff --git a/apps/web/package.json b/apps/web/package.json
@@ -1,6 +1,6 @@
 {
   "name": "web",
-  "version": "0.2.28",
+  "version": "0.2.29",
   "private": true,
   "scripts": {
     "build": "next build",

diff --git a/packages/angular/CHANGELOG.md b/packages/angular/CHANGELOG.md
@@ -1,5 +1,13 @@
 # @tryabby/angular
 
+## 2.0.1
+
+### Patch Changes
+
+- add fallback values to remote config
+- Updated dependencies
+  - @tryabby/core@5.0.1
+
 ## 2.0.0
 
 ### Major Changes

diff --git a/packages/angular/package.json b/packages/angular/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@tryabby/angular",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "scripts": {
     "ng": "ng",
     "start": "ng serve",

diff --git a/packages/cli/CHANGELOG.md b/packages/cli/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @tryabby/cli
 
+## 1.0.1
+
+### Patch Changes
+
+- add fallback values to remote config
+
 ## 1.0.0
 
 ### Major Changes

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@tryabby/cli",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "private": false,
   "main": "./dist/index.js",
   "bin": {

diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @tryabby/core
 
+## 5.0.1
+
+### Patch Changes
+
+- add fallback values to remote config
+
 ## 5.0.0
 
 ### Major Changes

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@tryabby/core",
-  "version": "5.0.0",
+  "version": "5.0.1",
   "description": "",
   "main": "dist/index.js",
   "files": [

diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
@@ -44,6 +44,9 @@ type Settings<
     devOverrides?: {
       [K in keyof RemoteConfig]: RemoteConfigValueStringToType<RemoteConfig[K]>;
     };
+    fallbackValues?: {
+      [K in keyof RemoteConfig]?: RemoteConfigValueStringToType<RemoteConfig[K]>;
+    };
   };
 };
 
@@ -85,7 +88,7 @@ export type AbbyConfig<
   tests?: Tests;
   flags?: FlagName[];
   remoteConfig?: RemoteConfig;
-  settings?: Settings<F.NoInfer<FlagName>>;
+  settings?: Settings<F.NoInfer<FlagName>, F.NoInfer<RemoteConfigName>, F.NoInfer<RemoteConfig>>;
   debug?: boolean;
 };
 
@@ -336,8 +339,18 @@ export class Abby<
     const defaultValue =
       this._cfg.settings?.remoteConfig?.defaultValues?.[this._cfg.remoteConfig?.[key]!];
 
-    if (storedValue === undefined && defaultValue !== undefined) {
-      return defaultValue as RemoteConfigValueStringToType<RemoteConfig[RemoteConfigName]>;
+    if (storedValue === undefined) {
+      // before we return the default value we check if there is a fallback value set
+      const fallbackValue = key in (this._cfg.settings?.remoteConfig?.fallbackValues ?? {});
+      if (fallbackValue) {
+        return this._cfg.settings?.remoteConfig?.fallbackValues?.[
+          key
+        ] as RemoteConfigValueStringToType<RemoteConfig[RemoteConfigName]>;
+      }
+
+      if (defaultValue != null) {
+        return defaultValue as RemoteConfigValueStringToType<RemoteConfig[RemoteConfigName]>;
+      }
     }
 
     this.log(`getRemoteConfig() => storedValue:`, storedValue);

diff --git a/packages/core/tests/base.test.ts b/packages/core/tests/base.test.ts
@@ -107,6 +107,33 @@ describe("Abby", () => {
     expect(abby.getRemoteConfig("remoteConfig1")).toBe("asdf");
   });
 
+  it("uses fallbacks", () => {
+    const abby = new Abby({
+      environments: [],
+      projectId: "",
+      remoteConfig: {
+        config1: "String",
+        config2: "String",
+      },
+      settings: {
+        remoteConfig: {
+          fallbackValues: {
+            config1: "fallback1",
+          },
+          defaultValues: {
+            String: "default",
+          },
+        },
+      },
+    });
+
+    abby.init({ flags: [], tests: [], remoteConfig: [] });
+
+    expect(abby.getRemoteConfig("config1")).toBe("fallback1");
+
+    expect(abby.getRemoteConfig("config2")).toBe("default");
+  });
+
   it("updates a local variant in dev mode", () => {
     process.env.NODE_ENV = "development";
 

diff --git a/packages/next/CHANGELOG.md b/packages/next/CHANGELOG.md
@@ -1,5 +1,13 @@
 # @tryabby/next
 
+## 5.0.1
+
+### Patch Changes
+
+- add fallback values to remote config
+- Updated dependencies
+  - @tryabby/react@5.0.1
+
 ## 5.0.0
 
 ### Major Changes

diff --git a/packages/next/package.json b/packages/next/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@tryabby/next",
-  "version": "5.0.0",
+  "version": "5.0.1",
   "description": "",
   "main": "dist/index.js",
   "files": [

diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md
@@ -1,5 +1,13 @@
 # @tryabby/react
 
+## 5.0.1
+
+### Patch Changes
+
+- add fallback values to remote config
+- Updated dependencies
+  - @tryabby/core@5.0.1
+
 ## 5.0.0
 
 ### Major Changes

diff --git a/packages/react/package.json b/packages/react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@tryabby/react",
-  "version": "5.0.0",
+  "version": "5.0.1",
   "description": "",
   "main": "dist/index.js",
   "files": [

diff --git a/packages/svelte/CHANGELOG.md b/packages/svelte/CHANGELOG.md
@@ -1,5 +1,13 @@
 # @tryabby/svelte
 
+## 2.0.1
+
+### Patch Changes
+
+- add fallback values to remote config
+- Updated dependencies
+  - @tryabby/core@5.0.1
+
 ## 2.0.0
 
 ### Major Changes

diff --git a/packages/svelte/package.json b/packages/svelte/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "@tryabby/svelte",
-	"version": "2.0.0",
+	"version": "2.0.1",
 	"main": "dist/index.umd.cjs",
 	"homepage": "https://docs.tryabby.dev",
 	"type": "module",