fix: make manually inserted script tag, spec compliant. #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airblast-dev
changed the title
ctron
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the HTML spec for the script tag "Neither tag is omissible." this means we must use opening and closing tags. While using
nipperthis mistake was silently corrected, so this is only coming up now.The behaviour of
lol_html's rewriter, is HTML spec compliant. Script tags that are inserted after an element without a closing tag, are not detected bylol_html. Meaning any modifications that are made, don't actually get applied.All of the examples in the repository are spec compliant with the HTML script tag, however the example script tags in trunk.rs are considered invalid by
lol_html, and incorrect by the HTML spec. The script tags on the site should also be corrected.This fixes the issues mentioned in: #742 (comment)