Skip to content

Commit

Permalink
if-change rule should not run on upstream. it only cares about curren…
Browse files Browse the repository at this point in the history
…t changes (#54)

1) if-change rule should not run on upstream. it only cares about
current changes
2) enable caching of trunk-toolbox runs
  • Loading branch information
EliSchleifer authored Nov 11, 2024
1 parent 4185c74 commit adeb908
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions .trunk/trunk.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ lint:
batch: true
success_codes: [0]
read_output_from: tmp_file
cache_results: true
disable_upstream: false
max_concurrency: 1
direct_configs: [toolbox.toml, log4rs.yaml]
Expand Down
5 changes: 5 additions & 0 deletions src/rules/if_change_then_change.rs
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@ pub fn ictc(run: &Run, upstream: &str) -> anyhow::Result<Vec<diagnostic::Diagnos
return Ok(vec![]);
}

if run.is_upstream() {
trace!("'if-change' rule doesn't run on upstream");
return Ok(vec![]);
}

debug!(
"scanning {} files for if_change_then_change",
run.paths.len()
Expand Down

0 comments on commit adeb908

Please sign in to comment.