Add dotnet format #468
Merged
Add dotnet format #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerJang27
force-pushed
the
tyler/dotnet-format
branch
from
8b2322c to
6337455
Compare
TylerJang27
changed the title
run_from syntaxrun_from syntax
TylerJang27
force-pushed
the
tyler/new-run-from
branch
from
298f386 to
8ff1594
Compare
TylerJang27
force-pushed
the
tyler/dotnet-format
branch
from
82cabee to
c46531b
Compare
|
@TylerJang27 - is this waiting on anything now? |
This works on all platforms except for M1 Mac, where it hangs for unknown reasons (and only on first run). I've been doing an ongoing investigation whenever I have free cycles. I've relayed this to the original user who requested this as well (who uses an M1 Mac). |
…5940cc8 on dev build
TylerJang27
force-pushed
the
tyler/dotnet-format
branch
from
6921321 to
1580894
Compare
TylerJang27
changed the title
run_from syntax
pat-trunk-io
approved these changes
Nov 9, 2023
pat-trunk-io
pushed a commit
that referenced
this pull request
Jan 22, 2024
Add [dotnet-format](https://github.com/dotnet/format/tree/main), which is run from [dotnet](https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-format). Some downloads are provided via [Microsoft](https://dotnet.microsoft.com/en-us/download/dotnet/7.0), but not in an easy templatizable format. This formatter does not work on Mac M1 for unknown reasons. The first run it appears to _sometimes_ spawn a zombie process that we can't terminate from, causing Trunk to hang. I've disabled the M1 download for that reason until we can figure out a fix. This will require a minor version bump since we bump the required trunk version. As a side note, dotnet-format sometimes leaves around other file artifacts as a result of its run, but I believe this is expected behavior within the dotnet ecosystem and these should appropriately be git-ignored. --------- Co-authored-by: Soo Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dotnet-format, which is run from dotnet. Some downloads are provided via Microsoft, but not in an easy templatizable format.
This formatter does not work on Mac M1 for unknown reasons. The first run it appears to sometimes spawn a zombie process that we can't terminate from, causing Trunk to hang. I've disabled the M1 download for that reason until we can figure out a fix.
This will require a minor version bump since we bump the required trunk version.
As a side note, dotnet-format sometimes leaves around other file artifacts as a result of its run, but I believe this is expected behavior within the dotnet ecosystem and these should appropriately be git-ignored.