-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stylelint packages #65
Conversation
In the Stylelint config, I see the following:
I think we need all of these packages (none are installed by default by Stylelint)? My guess is it only erred on the first one it looked for |
Also, it seems that |
I modified the stylelint config and extra packages to be correct (fixed) and also renamed the config to the js version, which is a "lower priority" as far as stylelint is concerned, allowing us to override it more easily, and allowing the collision to be detected in the marketing repo. |
@drwpow. This is ready for re-review when you get the chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 💯
Also thanks for the ping—I missed the earlier update (sorry!) |
The stylelint config was referencing a package that wasn't being installed.
Also upgrades the CLI.