Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stylelint packages #65

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Fix stylelint packages #65

merged 4 commits into from
Jan 23, 2024

Conversation

TylerJang27
Copy link
Collaborator

The stylelint config was referencing a package that wasn't being installed.

Also upgrades the CLI.

@drwpow
Copy link

drwpow commented Jan 18, 2024

In the Stylelint config, I see the following:

  - stylelint-config-standard-scss
  - stylelint-config-prettier
  - stylelint-config-clean-order

I think we need all of these packages (none are installed by default by Stylelint)?

My guess is it only erred on the first one it looked for

@drwpow
Copy link

drwpow commented Jan 19, 2024

Also, it seems that stylelint-config-prettier is incompatible with Stylelint >= 15.x, and the package has been deprecated. I propose we just nix it from the default config (which is separate from this PR, but also semi-related because this PR deals with packages from our default config)

@TylerJang27
Copy link
Collaborator Author

I modified the stylelint config and extra packages to be correct (fixed) and also renamed the config to the js version, which is a "lower priority" as far as stylelint is concerned, allowing us to override it more easily, and allowing the collision to be detected in the marketing repo.

@TylerJang27
Copy link
Collaborator Author

@drwpow. This is ready for re-review when you get the chance

Copy link

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯

@drwpow
Copy link

drwpow commented Jan 23, 2024

Also thanks for the ping—I missed the earlier update (sorry!)

@TylerJang27 TylerJang27 merged commit fbf6b36 into main Jan 23, 2024
3 checks passed
@TylerJang27 TylerJang27 deleted the tyler/fix-stylelint branch January 23, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants