Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRUNK-13680] Less misleading error log for 404 on get quarantining config #179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[TRUNK-13680] Less misleading error log for 404 on get quarantining config #179

wants to merge 1 commit into from

Conversation

max-trunk
Copy link
Contributor

TRUNK-13680

Adds custom error handling on 404s from /getQuarantiningConfig to override the default 'Your org slug may be incorrect..' 404 response

@trunk-staging-io Trunk-Staging.io
Copy link

trunk-staging-io bot commented Nov 25, 2024 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

dfrankland
dfrankland approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@dfrankland dfrankland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfrankland dfrankland dfrankland approved these changes

@federicoweber federicoweber Awaiting requested review from federicoweber

@pv72895 pv72895 Awaiting requested review from pv72895

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-trunk @dfrankland