Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131841 / 24.10.2 / ACL Editor Group/User Search Bug (by AlexKarpov98) #11104

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

bugclerk
Copy link
Contributor

Testing: see ticket.

Result:

Screen.Recording.2024-11-26.at.15.13.07.mov

Original PR: #11101
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131841

@bugclerk bugclerk requested a review from a team as a code owner November 27, 2024 10:30
@bugclerk bugclerk requested review from RehanY147 and removed request for a team November 27, 2024 10:30
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@664ba16). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ms/components/ix-combobox/ix-combobox.component.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #11104   +/-   ##
=====================================================
  Coverage                      ?   79.95%           
=====================================================
  Files                         ?     1573           
  Lines                         ?    51468           
  Branches                      ?     5939           
=====================================================
  Hits                          ?    41152           
  Misses                        ?    10316           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) November 27, 2024 14:44
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@AlexKarpov98 AlexKarpov98 merged commit 6a57500 into stable/electriceel Nov 27, 2024
7 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-131841-24.10.2 branch November 27, 2024 14:45
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants