Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-132750 / 25.04 / Minor improvements for containers #11102

Merged
merged 2 commits into from
Nov 27, 2024
Merged

NAS-132750 / 25.04 / Minor improvements for containers #11102

merged 2 commits into from
Nov 27, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Nov 26, 2024

Changes:

  • Clarifies what it means not to set CPU or memory.
  • Shows environment variables in a tooltip.

@undsoft undsoft requested a review from a team as a code owner November 26, 2024 15:50
@undsoft undsoft requested review from bvasilenko and removed request for a team November 26, 2024 15:50
@bugclerk bugclerk changed the title NAS-132750: Minor improvements for containers NAS-132750 / 25.04 / Minor improvements for containers Nov 26, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132750

william-gr
william-gr reviewed Nov 26, 2024
View reviewed changes
src/app/enums/virtualization.enum.ts Outdated
@@ -13,11 +13,13 @@ export const virtualizationTypeLabels = new Map<VirtualizationType, string>([
export enum VirtualizationStatus {
Running = 'RUNNING',
Stopped = 'STOPPED',
Unknown = 'Unknown',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNKNOWN, uppercase?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (7ad0021) to head (e18d7ce).
Report is 6 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11102      +/-   ##
==========================================
+ Coverage   82.34%   82.36%   +0.01%     
==========================================
  Files        1643     1645       +2     
  Lines       57484    57540      +56     
  Branches     5930     5936       +6     
==========================================
+ Hits        47333    47390      +57     
+ Misses      10151    10150       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft enabled auto-merge (squash) November 27, 2024 09:10
@undsoft undsoft merged commit b70831e into master Nov 27, 2024
11 checks passed
@undsoft undsoft deleted the NAS-132750 branch November 27, 2024 09:38
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@william-gr william-gr william-gr left review comments

@bvasilenko bvasilenko bvasilenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@undsoft @bugclerk @william-gr @bvasilenko