Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132643 / 24.10.2 / Rework ping logic #11094

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

bvasilenko
Copy link
Contributor

Testing:

Enter login page, authenticate, and then logout. Watch messages sent over websocket in browser's network log

Expected results:

  1. ping should be sent only when user is authenticated. In other words, ping should not be sent on "public" pages, such as login screen
  2. call core.ping should be done instead of sending { msg: 'ping' }

@bvasilenko bvasilenko requested a review from a team as a code owner November 25, 2024 06:48
@bvasilenko bvasilenko requested review from undsoft and removed request for a team November 25, 2024 06:48
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-132643: Rework ping logic NAS-132643 / 24.10.2 / Rework ping logic Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@fbfd1b9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/app/app.component.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #11094   +/-   ##
=====================================================
  Coverage                      ?   79.96%           
=====================================================
  Files                         ?     1573           
  Lines                         ?    51468           
  Branches                      ?     5940           
=====================================================
  Hits                          ?    41155           
  Misses                        ?    10313           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, clean work.

@bvasilenko bvasilenko merged commit 664ba16 into stable/electriceel Nov 26, 2024
7 checks passed
@bvasilenko bvasilenko deleted the NAS-132643-24.10.2 branch November 26, 2024 08:07
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants