-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-132423 / 25.04 / Add ix-datepicker component #11090
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11090 +/- ##
==========================================
+ Coverage 82.34% 82.35% +0.01%
==========================================
Files 1643 1647 +4
Lines 57484 57595 +111
Branches 5930 5937 +7
==========================================
+ Hits 47333 47433 +100
- Misses 10151 10162 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks pretty good to me.
One thing I noticed is that I can set 2020
year for example, form is counted as valid, but date picker dialog shows 2024 year instead (because 2020 is blocked - but actually selected via input)
Screen.Recording.2024-11-25.at.14.04.51.mov
Let's see what (maestro) @undsoft thoughts.
[tooltip]="tooltips.expires | translate" | ||
[required]="true" | ||
></ix-input> | ||
<ix-datepicker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the PR to properly handle differences in timezones and custom date formats user may have in settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR has been merged and conversations have been locked. |
Changes:
Add ix-datepicker component.
Testing:
For testing, check My API Keys page and try create or update an API key.